Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AssertJ for Java 21 support #270

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

basil
Copy link
Member

@basil basil commented Sep 6, 2023

Remove AssertJ which does not currently support Java 21. This also makes the test framework used in this plugin consistent with the test framework used in other Jenkins plugins and Jenkins core.

Testing done

Ran the tests on Java 21 before and after this PR. The tests failed before and passed after.

@basil basil added the test (release-drafter) label Sep 6, 2023
@basil basil requested a review from a team as a code owner September 6, 2023 20:01
@basil basil merged commit 9b6b844 into jenkinsci:master Sep 6, 2023
14 checks passed
@basil basil deleted the assertj branch September 6, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test (release-drafter)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant